Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block closing the notification permission dialog by tapping outside the bounds #5792

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Oct 24, 2023

Closes #5758

Why is this the best possible solution? Were any other approaches considered?

I think one way of closing the dialog (by clicking the ok button) is enough and we should block closing it by tapping outside the bounds.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Testing the dialog should be enough. Other parts of the app should not be affected.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg added needs testing high priority Should be looked at before other PRs/issues labels Oct 24, 2023
@srujner
Copy link

srujner commented Oct 25, 2023

Tested with Success!

Verified on device with Android 13

Verified cases:

@grzesiek2010 grzesiek2010 merged commit abe7a3b into getodk:v2023.3.x Oct 25, 2023
seadowg pushed a commit to seadowg/collect that referenced this pull request Oct 26, 2023
Block closing the notification permission dialog by tapping outside the bounds
seadowg pushed a commit to seadowg/collect that referenced this pull request Oct 30, 2023
Block closing the notification permission dialog by tapping outside the bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapping outside notification permission description dialog dismisses it with no way to grant permission
3 participants