Improvements around new statuses used by drafts in v2023.3 #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Oct 26, 2023
collect_app/src/androidTest/java/org/odk/collect/android/support/pages/EditSavedFormPage.java
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/activities/InstanceChooserList.java
Outdated
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
improvements_for_v2023.3
branch
from
ea0ae9a to
e8f947f
Compare
seadowg
approved these changes
Oct 31, 2023
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Oct 31, 2023
…23.3 Improvements around new statuses used by drafts in v2023.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr does not fix anything important but adds some improvements that should be included in v2023.3. I've investigated the places in the app where draft statuses are used and did not discover anything apart from: #5798 so this pr with improvements should be the last fix
Why is this the best possible solution? Were any other approaches considered?
The only thing of note is the fix for opening editable instances: 43071e0
It worked well but only because of the fact that
strCanEditWhenCompleteis always true for drafts. In the future, if we remove it we could introduce regression easily.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.