Fix multi select widget with no-buttons appearance

[seadowg]

Closes #5821

Why is this the best possible solution? Were any other approaches considered?

All widget implementations need to call widgetValueChanged() whenever their state changes for things like field list calculations to work and the call was simply missing in this case.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Shouldn't change anything other than fixing the issue! It'd be good to have a quick poke around with other appearance combos for widgets in general to see if we can find any other problematic ones.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• added a comment above any new strings describing it for translators
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[srujner]

Should the answer be saved after I uncheck and check again?

XRecorder_16112023_114109.mp4

[seadowg]

Should the answer be saved after I uncheck and check again?

Good question? What's the behaviour like in older versions?

[dbemke]

What's the behaviour like in older versions?

Select with no buttons didn't work in previous version (can't compare) but I changed the form so that there are buttons and compared it with this - the hidden answer is present until saving the form, after saving the form if the question was hidden the answer isn't saved... so it's the same I guess

[seadowg]

but I changed the form so that there are buttons and compared it with this - the hidden answer is present until saving the form, after saving the form if the question was hidden the answer isn't saved... so it's the same I guess

I think if the behaviour is consistent we're ok here. As long as the question is properly irrelevant, it shouldn't matter that the answer is "remembered". I guess in some cases that would actually be really useful!

[dbemke]

Tested with Success!

Verified on Android 10

Verified Cases:

• issue Questions are not updated if select_multiple used with no-buttons appearance on a field-list #5821 isn’t reproducible
• selects on a field-list with/without buttons in a required and not required questions
• don’t keep activities enabled/disabled
• adding, removing answers and minimizing the screen
• saving, editing, sending a form with select no buttons on a field-list

[srujner]

Tested with Success!

Verified on Android 13