Log original exception in retry rule and ignore test failing on Test Lab #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,9 +15,11 @@ class RetryOnDeviceErrorRule : TestRule { | |||
| } catch (e: Exception) { | |||
| if (e is PerformException) { | |||
| Timber.w("RetryOnDeviceErrorRule: Retrying due to PerformException!") | |||
| Timber.e(e) | |||
There was a problem hiding this comment.
Do you think we need both those logs? Maybe the first one is redundant now?
There was a problem hiding this comment.
Yeah we do. It'll help find the retries as you'll be able to search for RetryOnDeviceErrorRule in the logs.
seadowg
changed the title
grzesiek2010
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetryOnDeviceErrorRulecurrently obscures the original exception. This can make it hard to diagnose failures that only happen on CI.I've added an issue to track fixing the ignored test.