Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MultiClickSafeButton instad of MaterialButton directly #6003

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Mar 6, 2024

Closes #5911

Why is this the best possible solution? Were any other approaches considered?

MultiClickSafeButton is what we have used for a long time. Unfortunately, we do not always remember that it should be used instead of the MaterialButton directly so I've reviewed the whole project and fixed everything at once.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I think we can focus on verifying that the issue is fixed. I used the same fix in many other places in the app where similar problems could also occur but it doesn't make sense to list all of those places. We are at the beginning of the release cycle so we have a lot of time to test those changes on a daily basis.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review March 6, 2024 13:21
@grzesiek2010 grzesiek2010 requested a review from seadowg March 6, 2024 13:21
@grzesiek2010 grzesiek2010 merged commit 2f8d417 into getodk:master Mar 25, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Mar 27, 2024

Tested with success!

Verified on devices with Android: 10, 14

Verified cases:

@WKobus
Copy link

WKobus commented Mar 27, 2024

Tested with success!

Verified on devices with Android: 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi clicking Delete button in the audio widget and deleting the recorded sound twice crashes the app
4 participants