Fix flaky FieldListUpdateTest test
#6077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Apr 15, 2024
| @@ -557,6 +557,17 @@ abstract class Page<T : Page<T>> { | |||
| return destination | |||
| } | |||
|
|
|||
| fun selectTextField(label: String, index: Int = 0): T { | |||
| closeSoftKeyboard() | |||
There was a problem hiding this comment.
If you close the keyboard before clicking on another text field then this test does not cover the original scenario anymore and doesn't make sense.
The original issue was that:
- There was a long list of questions.
- The first question was a text question.
- The last question was a numeric question (so that the keyboard type is different and will trigger calling
onLayoutChangeonodkviewonce you switch from the first one to the last one). - You add an answer to the first one (so that the text keyboard is open)
- Then you click on the last question (and the keyboard needs to be updated which as I said above calls
onLayoutChangeonodkview).
If you close the keyboard between steps 4 and 5 then onLayoutChange (what was the cause of the issue) will never be called.
There was a problem hiding this comment.
Ah right! Well this is not a good solution then 😆. Back to the drawing board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5996
This test actually failed locally using API 34 which made it much easer to find the problem (trying to scroll while the keyboard is up). The test still passes running in API 30.