Fixed geotrace and geoshape widgets in read-only mode #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-6096
branch
from
d73182a to
a25d18f
Compare
grzesiek2010
force-pushed
the
COLLECT-6096
branch
from
a25d18f to
533e46c
Compare
seadowg
requested changes
Apr 30, 2024
| intent.putExtra(GeoPolyActivity.EXTRA_POLYGON, polyline) | ||
| val scenario = launcherRule.launch<GeoPolyActivity>(intent) | ||
| mapFragment.ready() | ||
| scenario.onActivity { activity: GeoPolyActivity -> |
There was a problem hiding this comment.
All these onActivity calls could be combined. Same for the below test.
seadowg
approved these changes
May 2, 2024
|
Tested with Success! Verified on devices with Android 10, 14 Verified Cases:
|
|
Tested with Success! Verified on device with Android 11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6096
Why is this the best possible solution? Were any other approaches considered?
Apart from disabling the save icon in read-only mode, I've decided to make lines and polygons not draggable: 6b87ee2 it was a problem with the disabled saved button but was confusing so I think we should introduce both improvements,
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should disable the save button in read-only mode and also make lines and polygons not draggable. Nothing else should be affected but we need to test the maps as a whole to make sure that everything is fine.
Do we need any specific form for testing your changes? If so, please attach one.
The form is attached to the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass