Remove ignore from field list test #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
commented
Jun 6, 2024
| * https://stackoverflow.com/a/39756832 | ||
| * | ||
| */ | ||
| @Deprecated("this matcher is stateful and will cause problems if used more than once") |
There was a problem hiding this comment.
The problems with this are actually mentioned in a comment on the SO answer, but for some reason the answer has stayed up. I've flagged it, so others don't run into the same problems.
To be clear, I'm not sure if it actually broke anything for us, but while experimenting with different ways of scrolling and clicking I ended up running into problems caused by the state here.
seadowg
commented
Jun 6, 2024
| } | ||
|
|
||
| override fun matchesSafely(item: View): Boolean { | ||
| return if (item is QuestionWidget) { |
There was a problem hiding this comment.
I'm not a big fan of UI tests that know this much about the view hierarchy, but I've tried to keep this as general as possible: QuestionWidget is a pretty fundamental view type and there just needs to be a text_label somewhere within it for this to work (the actual structure doesn't matter).
grzesiek2010
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5996
Why is this the best possible solution? Were any other approaches considered?
I was only able to get this to fail once, only on Test Lab and not since 40148aa. The main change I've made here is to deprecate
withIndexdue to it presenting subtle problems (because it's stateful). I suspect some of the other work we've done on UI tests recently has made this more stable, and I'm optimistic that the new method for scrolling to a question is more robust as well.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This just changes tests, so there is nothing to verify.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest