Make sure instances show in the correct project #6182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6124
Why is this the best possible solution? Were any other approaches considered?
The instances just needed qualified by project in the data service so they don't end up in the wrong place.
We probably also want to do the same rework for the counts in
InstancesDataService
, but we get away with them being non project specific right now because we always update them when viewing the Main Menu. I'd also like to get #6158 merged before making changes like that as it should introduce better structuring for data services and make them easier to test.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The code changed really only affects the saved form delete page so that's the main thing to concentrate on when testing.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest