Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure instances show in the correct project #6182

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 11, 2024

Closes #6124

Why is this the best possible solution? Were any other approaches considered?

The instances just needed qualified by project in the data service so they don't end up in the wrong place.

We probably also want to do the same rework for the counts in InstancesDataService, but we get away with them being non project specific right now because we always update them when viewing the Main Menu. I'd also like to get #6158 merged before making changes like that as it should introduce better structuring for data services and make them easier to test.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The code changed really only affects the saved form delete page so that's the main thing to concentrate on when testing.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review June 11, 2024 16:34
@seadowg seadowg requested a review from grzesiek2010 June 11, 2024 16:34
@grzesiek2010 grzesiek2010 merged commit ca3512c into getodk:master Jun 11, 2024
6 checks passed
@seadowg seadowg deleted the delete-form-projects branch June 12, 2024 08:51
@srujner
Copy link

srujner commented Jun 12, 2024

Tested with Success!

Verified on device with Android 13

Verified cases:

@dbemke
Copy link

dbemke commented Jun 13, 2024

Tested with Success!

Verified on device with Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sent form in one project appear in another project in "Delete form- Saved forms"
4 participants