Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-existing layers #6184

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Handle non-existing layers #6184

merged 3 commits into from
Jun 13, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jun 12, 2024

Closes #6176

Why is this the best possible solution? Were any other approaches considered?

If the selected layer does not exist anymore it should be cleared and the none option should be selected in offline layers.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This should only fix the issue and have no side effects.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg June 12, 2024 13:45
@grzesiek2010 grzesiek2010 marked this pull request as ready for review June 12, 2024 13:45
@grzesiek2010 grzesiek2010 added the high priority Should be looked at before other PRs/issues label Jun 13, 2024
@seadowg seadowg merged commit 93232c0 into getodk:master Jun 13, 2024
6 checks passed
@srujner
Copy link

srujner commented Jun 17, 2024

Tested with Success!

Verified on device with Android 13

Verified cases:

  • Issue is no longer reproducing;
  • Regression check on Maps;
  • Offline Layers tested in General;
  • Different Map sources;

@dbemke
Copy link

dbemke commented Jun 17, 2024

Tested with Success!

Verified on device with Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app crashes after removing manually an offline layer in the directory and going to settings-maps
4 participants