Prevent double taps on multi select actions

androidshared/src/main/java/org/odk/collect/androidshared/ui/multiclicksafe/DoubleClickSafeMaterialButton.kt

@@ -0,0 +1,24 @@
+package org.odk.collect.androidshared.ui.multiclicksafe
+
+import android.content.Context
+import android.util.AttributeSet
+import com.google.android.material.button.MaterialButton
+
+class DoubleClickSafeMaterialButton @JvmOverloads constructor(
+    context: Context,
+    attrs: AttributeSet? = null,
+    defStyleAttr: Int = 0
+) : MaterialButton(context, attrs, defStyleAttr) {
+
+    override fun performClick(): Boolean {
+        return allowClick() && super.performClick()
+    }
+
+    /**
+     * Use [MultiClickGuard] with a scope unique to this object (class name + hash).
+     */
+    private fun allowClick(): Boolean {
+        val scope = javaClass.name + hashCode()
+        return MultiClickGuard.allowClick(scope)
+    }
+}

androidshared/src/main/java/org/odk/collect/androidshared/ui/multiclicksafe/MultiClickGuard.kt

@@ -15,21 +15,21 @@ object MultiClickGuard {
     }
 
     /**
-     * Debounce multiple clicks within the same screen
+     * Debounce multiple clicks within the same scope
      *
-     * @param screenName The name of the screen. If not provided, the Java class name of the element
+     * @param scope If not provided, the Java class name of the element
      * is used. However, this approach is imperfect, as elements on the same screen might belong to
      * different classes. Consequently, clicks on these elements are treated as interactions occurring
      * on two distinct screens, not protecting from rapid clicking.
      */
     @JvmStatic
     @JvmOverloads
-    fun allowClick(screenName: String = javaClass.name, clickDebounceMs: Long = 1000): Boolean {
+    fun allowClick(scope: String = javaClass.name, clickDebounceMs: Long = 1000): Boolean {
         if (test) {
             return true
         }
         val elapsedRealtime = SystemClock.elapsedRealtime()
-        val isSameClass = screenName == lastClickName
+        val isSameClass = scope == lastClickName
         val isBeyondThreshold = elapsedRealtime - lastClickTime > clickDebounceMs
         val isBeyondTestThreshold =
             lastClickTime == 0L || lastClickTime == elapsedRealtime // just for tests
@@ -38,7 +38,7 @@ object MultiClickGuard {
 
         if (allowClick) {
             lastClickTime = elapsedRealtime
-            lastClickName = screenName
+            lastClickName = scope
         }
         return allowClick
     }

lists/src/main/res/layout/multi_select_controls_layout.xml

@@ -19,7 +19,7 @@
         android:layout_weight="1"
         android:text="@string/select_all" />
 
-    <com.google.android.material.button.MaterialButton
+    <org.odk.collect.androidshared.ui.multiclicksafe.DoubleClickSafeMaterialButton
         android:id="@+id/action"
         style="?materialButtonStyle"
         android:layout_width="0dp"