Do not support the masked appearance in numeric questions #6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Jun 17, 2024
|
In text numbers question same issue occurs as before in other number questions - answer entered in text field can be seen on android keyboard in landscape view. |
|
I'd completely forgotten about text number widget! Could you file that as a separate issue please? |
|
Tested with success! Verified on device with android 14 Verified cases:
|
|
Tested with success! Verified on device with android 10 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6122
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue we should stop supporting the masked appearance in numeric questions as this is not easy to achieve because of Android limitations.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This brings some more changes than just fixing the issue. We have decided that we should not support the masked appearance in numeric questions (integer/decimal) so now it will be available only for text questions (default text question/external text question/number text question).
Do we need any specific form for testing your changes? If so, please attach one.
The form from the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest