Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SingleSelectViewModel #6239

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jun 28, 2024

Closes #6228

Why is this the best possible solution? Were any other approaches considered?

I've found some bugs in the implementation of managing selectable items that I've fixed:

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please focus on testing selecting offline layers / changing the selection / changing to none etc. as the code responsible for this has been updated. I don't think other parts of the feature could be affected here.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review June 28, 2024 10:31
@lognaturel lognaturel merged commit a57bbbc into getodk:master Jun 28, 2024
6 checks passed
@seadowg seadowg requested review from seadowg and removed request for seadowg July 1, 2024 08:08
@srujner
Copy link

srujner commented Jul 1, 2024

Tested with Success

@dbemke
Copy link

dbemke commented Jul 1, 2024

Tested with Success on a device with Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to change an offline layer to "none”
4 participants