Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for beta #6240

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Jun 28, 2024

Updates translations for release candidate beta, adding Traditional Chinese.

Why is this the best possible solution? Were any other approaches considered?

The only significant change is adding Traditional Chinese. In Transifex, we were able to use the generic zh-Hant locale code but Android doesn't have it. I read discussions like this one and decided zh-TW was most appropriate. This also matches the discussion on the ODK forum.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

More translations.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel marked this pull request as ready for review June 28, 2024 17:34
@lognaturel lognaturel merged commit 1729fa4 into getodk:master Jun 28, 2024
6 checks passed
@lognaturel lognaturel deleted the update-translations branch June 28, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants