Fixed memory leaks in form-filling #6275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5976
Why is this the best possible solution? Were any other approaches considered?
The first problem I was able to reproduce was building
SavepointsRepositoryProvider
and passing activity as a context.SavepointsRepositoryProvider
similar to other database repository providers needs a context but it should be the application one instead.Another problem was passing data to
BackgroundLocationHelper
. Here instead of using lambda functions to pass the form controller we should passformSessionRepository
andsessionId
to letBackgroundLocationHelper
get the form controller when it needs it similar to what other objects constructed inFormEntryViewModelFactory
do.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please make sure the leaks do not occur anymore. Additionally, it would be good to test background audio recordings briefly (just to check if it works with no crashes) as the code related to this functionality has been updated.
There might be other leaks caused by device rotation but I was able to reproduce only the two described above. If there is something more you can still see please let me know.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest