-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trunkVersion
and branchId
support
#6276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
force-pushed
the
trunk-version
branch
2 times, most recently
from
July 22, 2024 19:37
aefaf8c
to
70c6280
Compare
seadowg
changed the title
Add trunkVersion and branchId support
Add Jul 23, 2024
trunkVersion
and branchId
support
6 tasks
seadowg
force-pushed
the
trunk-version
branch
2 times, most recently
from
July 29, 2024 15:49
afee21c
to
81b419a
Compare
grzesiek2010
requested changes
Jul 31, 2024
entities/src/test/java/org/odk/collect/entities/LocalEntityUseCasesTest.kt
Show resolved
Hide resolved
grzesiek2010
approved these changes
Jul 31, 2024
Tested with success Verified on device with Android 14 Verified cases:
|
Tested with success Verified on device with Android 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6245
Blocked by #6267As well as adding support for forms to receive
__trunkVersion
and__branchId
and keeping track of these values correctly, this also changes how we increment__version
. Before, Collect would parse thebaseVersion
, increment it and then store the result. This meant that a form might manipulate thebaseVersion
in an unexpected way which would Collect would honour. After chatting with @lognaturel, we've decided that this was actually an incorrect implementation of the following line in the spec:Instead, we now increment our own representation of
__version
(Entity#version
) and ignore thebaseVersion
in submissions.I've also cleaned up how Collect treats forms that have both an
update
and acreate
action and added tests to define that behaviour.Why is this the best possible solution? Were any other approaches considered?
Not a lot to discuss here! I'll put comments inline for anything that seems worth mentioning.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This is mostly all additional, but there's a risk that changes to the way we increment version and to how we treat forms that have both an
update
andcreate
action might alter how we expect Collect to behave. It'd be worth testing both of these out and checking we're happy with how everything works.Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest