Target API 34 #6291
Merged
Target API 34 #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Jul 30, 2024
|
@getodk/testers I mostly agree with @grzesiek2010 that we should test this after merge as part of our day to day, but I think the one thing I'd like to see tested here before merge is the external app integrations (due to this change). It would be good to do a pass with the Collect Tester app. |
|
I checked tester intents app, Collect answer provider app, ODK counter app and they seems to work well with Collect. I also had a look at different widgets redirecting to different app (e.g. custom camera, printer). Verified on Android 14 and 10. |
|
Tested with Success! Additionally I've tested shortcuts on Android 11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6147
Why is this the best possible solution? Were any other approaches considered?
As described in the issue we need to update the target SDK version every year since it's a requirement for Google Play apps.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think we can merge this pull request without testing and allow the team to test the changes daily while testing other functionalities.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest