Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed project icon layout #6317

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Aug 8, 2024

Closes #6312

Why is this the best possible solution? Were any other approaches considered?

The icon was not centered in its container and that was the reason why the ripple effect was also not centered.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Only the layout of the project con has been updated so it's a safe change. As long as the icon looks good everything should be fine.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from alyblenkin August 8, 2024 13:05
@grzesiek2010 grzesiek2010 marked this pull request as ready for review August 8, 2024 13:31
@grzesiek2010 grzesiek2010 requested a review from seadowg August 9, 2024 06:04
@seadowg seadowg merged commit 3669ada into getodk:master Aug 9, 2024
6 checks passed
@seadowg seadowg removed their request for review August 9, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with pressed state for project settings
3 participants