Fixed displaying required questions with audio attachments #6332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Aug 15, 2024
...t_app/src/androidTest/java/org/odk/collect/android/feature/formentry/RequiredQuestionTest.kt
Outdated
Show resolved
Hide resolved
...t_app/src/androidTest/java/org/odk/collect/android/feature/formentry/RequiredQuestionTest.kt
Outdated
Show resolved
Hide resolved
seadowg
approved these changes
Aug 22, 2024
|
Tested with Success! Verified on a device Android 10 Verified Cases:
|
|
Tested with Success Verified on device with Android 14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6327
Why is this the best possible solution? Were any other approaches considered?
There was some redundant code updating question labels based on the state of audio attachments (stopped/playing). This code was unnecessary because we only change the color of the labels, not the text. It seems this was needed a long time ago but was never removed. This update didn't account for the state of the questions (such as whether they were required), which was the cause of the issue.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Apart from testing if the issue is fixed. this change requires testing how question labels behave based on the state of their audio attachments. The color of the question label should update accordingly (blue when the audio is playing).
Do we need any specific form for testing your changes? If so, please attach one.
Any form with required questions that have audio attachments like the one from the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest