Address review comments for PR 6118, 6169, 6175

[grzesiek2010]

Closes #6174

Why is this the best possible solution? Were any other approaches considered?

I was meant to handle this earlier, but I got caught up with other tasks and kept postponing it. Better late than never. I've addressed most of the comments, though not all of them (some were outdated and not relevant anymore). Some are less critical and/or too risky, as they would require retesting the functionality so I skipped them. I think what I've fixed is enough and we can merge the changes and close the issue.
The comments I skipped are:

• Convert reference layer selection to bottom sheet in select one from map #6118 (comment): I skipped this one because it doesn't seem that important. It doesn’t offer a significant advantage, so taking the risk to add such a refactoring doesn’t make much sense. Also, the code has changed significantly since the comment was added.
• Allow MBTile files to be imported #6169 (comment): Testing this is not straightforward, so it might be better to file a separate issue if it’s considered important. We also have a similar method elsewhere, so a broader refactoring might be necessary.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I think it doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• added any new strings with date formatting to DateFormatsTest
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

This doesn't really fit the pattern of the other helpers in Interactions/Assertions. Maybe instead you could pull out a custom helper (maybe to ViewMatchers) like atPositionInRecyclerView(listId: Int, position: Int, childViewId: Int): Matcher<View that you can then use with our helpers like clickOn:

clickOn(atPositionInRecyclerView(R.id.layers, 1, R.id.path))

[grzesiek2010]

Done.

[seadowg]

I've added "needs testing" to this as it derisks releasing it as part of the next hotfix. The main thing to check here is just a general run through of offline layer importing/management. There's no behaviour changes - just code and test improvements.

[srujner]

Tested with Success!

Verified on Device with Android 10,14

Verified cases:

• Importing/Managing Offline layers;
• Adding/Deleting Layers from Select Offline Layers panel and from Settings;
• Regression check on forms with Geo Questions;
• Select One from map;
• Different map sources.