Set user property when there is a static CSV and entity list clash #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6455
As well as the case we're worried about this will also detect a couple that won't be a problem:
people.csvin a project that has apeopleentity list, but the instance ID is notpeopleand so is safe (static-peoplefor example).people.csvin a project that has apeopleentity list, but the CSV is not being used as thesrcfor a secondary instance.Both these cases should be very rare though. I've also updated the name of the user property we were using to track metered non-cellular connections as we'd forgotten to set the user property up on Firebase and the name we were using was too long (there is a 40-character limit).