Do not lock the forms db when a form uses entities but is started in view-only mode #6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Oct 30, 2024
| @@ -1144,6 +1144,37 @@ class FormUriActivityTest { | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `When attempting to view a non-editable form that uses entities and the forms database is locked then start form for view only`() { | |||
There was a problem hiding this comment.
Would this test not be enough? We'd maybe want to add an assertion that here that opening the view-only form doesn't lock the forms change lock, but I'm not sure if we need the two connected tests?
There was a problem hiding this comment.
I have added one extra test here and removed those connected ones.
grzesiek2010
force-pushed
the
COLLECT-6485
branch
from
0e7859a to
8d9e47f
Compare
seadowg
requested changes
Oct 31, 2024
|
|
||
| fun clickOnExit(): SendFinalizedFormPage { | ||
| clickOnString(org.odk.collect.strings.R.string.exit) | ||
| return SendFinalizedFormPage() |
There was a problem hiding this comment.
This should be return SendFinalizedFormPage().assertOnPage()
There was a problem hiding this comment.
Actually, this method is no longer used so I removed it al all.
seadowg
approved these changes
Oct 31, 2024
|
Tested with Success! Verified on a device with Android 10 Verified cases:
|
|
Tested with Success! Verified on a device with Android 15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6485
Why is this the best possible solution? Were any other approaches considered?
When opening forms in view-only mode (forms that can't be edited), it doesn't make sense to block downloading updates, nor does it make sense to block opening such forms during these processes.
There’s nothing to discuss regarding the implementation, as the location where this case needs to be handled is clear -
FormUriActivity.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We need to test opening finalized and sent forms (forms that can't be edited) to ensure they don't block form updates and can still be opened during such processes.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest