Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require a label for Entity updates #6515

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Nov 15, 2024

Closes #6511

Why is this the best possible solution? Were any other approaches considered?

There’s nothing to discuss here, as no alternative solutions were considered.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Creating entities without labels should still not be possible, as before. However, when updating existing entities, if a label is missing or empty, the existing label should be retained.

Do we need any specific form for testing your changes? If so, please attach one.

I used:
entities_update.xlsx
entities_registration.xlsx

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review November 15, 2024 19:32
@lognaturel lognaturel requested a review from seadowg November 18, 2024 15:12
@seadowg seadowg merged commit 3975458 into getodk:master Nov 18, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Nov 19, 2024

Tested with Success!

Verified on a device with Android 10

Verified cases:

  • issue Don't require a label for Entity updates #6511 works as expected
  • trying to create a local entity with an empty label
  • updating an entity so that the label is empty and trying to update it again
  • checking the created entity in Central

@WKobus
Copy link

WKobus commented Nov 19, 2024

Tested with Success!

Verified on a device with Android 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require a label for Entity updates
4 participants