Document styling lines and polygons #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
reviewed
Apr 22, 2024
| - **marker-color**: a valid long or short hex color code used to represent that marker's color (e.g. ``#aaccee`` or ``#ace``) | ||
| - **marker-symbol**: a single character used as that choice's marker (e.g. ``A`` or ``7`` or ``🏥`` or ``🟢``) | ||
| - **marker-color**: a valid long or short hex color representing the color of a marker (e.g. ``#aaccee`` or ``#ace``) | ||
| - **marker-symbol**: a single character displayed on a marker (e.g. ``A`` or ``7`` or ``🏥`` or ``🟢``) |
There was a problem hiding this comment.
The two first ones only apply to points, right? Maybe we should make that explicit. I can see someone expecting each vertex to have a marker or a symbol to show up in the middle of a polygon.
lognaturel
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1780
What is included in this PR?
This documents the new properties for styling lines and polygons added in getodk/collect#6083