Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce isParentOf as alias for isAncestorOf and mark as deprecated #519

Closed
lognaturel opened this issue Dec 13, 2019 · 4 comments · Fixed by #529
Closed

Re-introduce isParentOf as alias for isAncestorOf and mark as deprecated #519

lognaturel opened this issue Dec 13, 2019 · 4 comments · Fixed by #529
Assignees
@grzesiek2010
Labels
in progress

Comments

@lognaturel
Copy link
Member

As @grzesiek2010 has discovered, isParentOf is used in Collect (https://github.com/opendatakit/collect/pull/3536/files) and really should be part of the public API.
@grzesiek2010 grzesiek2010 self-assigned this Dec 13, 2019
@ggalmazor
Copy link
Contributor

Thanks!

@ggalmazor ggalmazor mentioned this issue Dec 18, 2019
Merged
@lognaturel lognaturel mentioned this issue Dec 18, 2019
Closed
3 tasks
@ggalmazor
Copy link
Contributor

Hi, @grzesiek2010! I'm not sure if you're working on this. I could throw a quick PR with the solution during my morning today

@getodk-bot
Copy link
Member

getodk-bot commented Dec 30, 2019 •
edited
Loading

Hello @grzesiek2010, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@grzesiek2010 grzesiek2010 self-assigned this Jan 7, 2020
@grzesiek2010
Copy link
Member

Hi, @grzesiek2010! I'm not sure if you're working on this. I could throw a quick PR with the solution during my morning today

I had a Christmas break. I'll create a pr tomorrow.

@grzesiek2010 grzesiek2010 mentioned this issue Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grzesiek2010 grzesiek2010

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added isParentOf() method back as alias for isAncestorOf() grzesiek2010/javarosa
4 participants
@ggalmazor @lognaturel @grzesiek2010 @getodk-bot