Use renamed isAncestorOf() method

[grzesiek2010]

What has been done to verify that this works as intended?

Tested collect with javarosa's master branch.

Why is this the best possible solution? Were any other approaches considered?

in https://github.com/opendatakit/javarosa/pull/515/files#diff-0c84c5364a094f70c8aa2c2ca3376a1a
the method isParentOf() has been renamed to isAncestorOf(). We use it in Collect so we need to merge this pr one we add javarosa with the mentioned fix.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

@grzesiek2010 am I right in thinking we can't merge this until the next JavaRosa release but that if we don't our app will fail to compile (as isParent won't exist)?

[lognaturel]

we can't merge this until the next JavaRosa release

Correct. I wonder whether it might be easier to re-introduce this when the JR update happens so we don't risk merging something broken.

our app will fail to compile (as isParent won't exist)

This was an accidental API change and isParentOf will be re-introduced as deprecated: getodk/javarosa#519. Using isAncestorOf will certainly be preferable.

[grzesiek2010]

I wonder whether it might be easier to re-introduce this when the JR update happens so we don't risk merging something broken.

Ok so I'm closing for now. I added it to my private todo list so I won't forget to reopen.