Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

getodk / javarosa Public

Notifications You must be signed in to change notification settings
Fork 107
Star 54

Code
Issues 99
Pull requests 10
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Issue 524 remove redundant dag cycle check#526

Merged

lognaturel merged 16 commits intogetodk:mastergetodk/javarosa:masterfrom ggalmazor:issue_524_remove_redundant_dag_cycle_checkCopy head branch name to clipboard

Jan 8, 2020

+461-92

Conversation Commits16 (16)Checks Files changed

Commits

Commits on Jan 8, 2020

Create regression tests to verify that DAG cycles can't be defined
ggalmazor
committed
Add new DAG cycle detection test cases
ggalmazor
committed
Generalize form generation for DAG cycle check test cases
ggalmazor
committed
Extend the DAG behavior coverage with more cases of cycle detection
ggalmazor
committed
Remove the first cycles check
ggalmazor
committed
Fix expected exception types and messages in dag tests
ggalmazor
committed
Improve the Triggerable.toString() output for humans
ggalmazor
committed
Extract the verb into the enum's value for reuse
ggalmazor
committed
Extract dupe code to the abstract class and reuse
ggalmazor
committed
Pull up if block to make the decision on the calling site
ggalmazor
committed
Always compute dependent triggerables to detect cycles by self-reference and throw an exception if this happens
ggalmazor
committed
Extract method that throws the DAG cycle exception and reuse
ggalmazor
committed
Only consider edges from dependant triggerables if the current triggerable can actually trigger them in cascade
ggalmazor
committed
Improve ConditionAction enum value names and textual descriptions
ggalmazor
committed
Fix relevance expression in test
ggalmazor
committed
Simplify calculate expressions
ggalmazor
committed

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.