Issue 532 selectchoice getvalue deserialization bug

[ggalmazor]

Closes #532

What has been done to verify that this works as intended?

Added automated regression test

Why is this the best possible solution? Were any other approaches considered?

It's a straightforward change to make deserialization work with the same constraints as the normal constructors.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Users having issues with deserialization of forms under the same scenario should not get errors anymore.

Do we need any specific form for testing your changes? If so, please attach one.

Nope.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

[codecov-io]

Codecov Report

Merging #533 into master will increase coverage by 0.14%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##             master    #533      +/-   ##
===========================================
+ Coverage     52.85%     53%   +0.14%     
- Complexity     3103    3111       +8     
===========================================
  Files           245     245              
  Lines         13340   13340              
  Branches       2566    2566              
===========================================
+ Hits           7051    7071      +20     
+ Misses         5468    5451      -17     
+ Partials        821     818       -3

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/org/javarosa/core/model/SelectChoice.java	81.39% <60%> (+37.2%)	19 <0> (+4)	⬆️
...org/javarosa/core/util/externalizable/ExtUtil.java	58.29% <0%> (+0.4%)	87% <0%> (+2%)	⬆️
.../org/javarosa/core/reference/ReferenceManager.java	61.7% <0%> (+1.06%)	21% <0%> (+1%)	⬆️
...main/java/org/javarosa/core/model/QuestionDef.java	79.54% <0%> (+1.51%)	49% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf184a7...0c1a933. Read the comment docs.