Handle empty saveto questions #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels like it's more of a contract between JavaRosa and the client so more appropriate at the top level.
lognaturel
reviewed
Oct 21, 2022
| return new Pair<>(saveTo.getSecond(), answer); | ||
| IAnswerData answerData = mainInstance.resolveReference(reference).getValue(); | ||
|
|
||
| if (answerData != null) { |
lognaturel
approved these changes
Oct 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issues found in collect/#5294
What has been done to verify that this works as intended?
New tests
Why is this the best possible solution? Were any other approaches considered?
The only alternative was to store empty answers as
nullin their respective properties, but after discussing with the Central team, we felt it was easier to treat these cases as an empty string so that we can keep entity properties non-nullable.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Not a big change here. Should only affect questions with
savetoattributes