Update entities features for new spec #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
The test with a dynamic create expression wasn't setting the value of /data/join correctly. Since it was only checking for the no creation case which was satisfied with no change in /data/join, it kind of was testing what it was supposed to. I think it's helpful to have both the create and non-create case for that test so I went ahead and added that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for JavaRosa to comply with getodk/xforms-spec#299
What has been done to verify that this works as intended?
Updated tests
Why is this the best possible solution? Were any other approaches considered?
Just a few small tweaks to make sure entity forms work correctly. Not really much to discuss!
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Pretty low risk as only a couple of things had to change. Best thing to double-check is that my updated test example forms actually match the new spec.