Values referenced from jr:repeat-count should be coerced to int #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686
What has been done to verify that this works as intended?
I've tested the fix with ODK Collect and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
There is not much to discuss here. As mentioned in the issue the value that represents the number of repeats should be coerced to int.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's rather a safe change that might affect only how we determine the number of repeats so testing this functionality should be enough.
Do we need any specific form for testing your changes? If so, please attach one.
Any form that allows specifying the number of repeats. I used this one:
RepeatCountTest.xlsx
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.