Support optimizations for more expressions #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents problems that might arise from custom functions
seadowg
force-pushed
the
extra-expressions
branch
from
4f950f2 to
8770307
Compare
lognaturel
reviewed
Dec 1, 2023
| // This call triggers the correct population of dynamic choices. | ||
| questionPrompt.getAnswerValue(); | ||
| // // This call triggers the correct population of dynamic choices. | ||
| // questionPrompt.getAnswerValue(); |
There was a problem hiding this comment.
This was definitely needed originally. I'm not sure at what point it stopped being required. Maybe when we started caching? Do we need to look deeper into it or can we just delete these two lines?
There was a problem hiding this comment.
In v3.0.0, it was definitely needed
lognaturel
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #726
Blocked by #722What has been done to verify that this works as intended?
New tests and verified manually with Collect.
Why is this the best possible solution? Were any other approaches considered?
Discussed in #726.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I've moved some of the filter chain stuff around (it now lives in
FormDef) so there's risk I've broken some of the existing caching/predicate evaluation along with adding support for the new expressions. Hopefully we have enough testing around this stuff to catch problems, but it's always good to see if you can spot edge cases while reviewing!