Use placeholder root for empty external secondary instance #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #743
This comes up for users who build forms that both create and use an Entity List. The first time the form is used, the Entity List is empty and this crash occurs.
What has been done to verify that this works as intended?
Added a test
Why is this the best possible solution? Were any other approaches considered?
I considered specifically targeting CSVs since there's concept of header-only XML and geojson files but I decided that the case is generic -- a form designer may want to start by attaching an empty file and then later add to that file (programmatically, with Entities, etc).
I think treating this the same way as an empty file makes the most sense because they are so similar.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I can't think of any risk to existing functionality. Maybe someone could argue it would make it harder to notice an unintentionally empty file but I don't think that's a big problem.
Do we need any specific form for testing your changes? If so, please attach one.
See test.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.