Additions needed for offline entity creation #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two things needed to implement offline entities in Collect:
EntityFormFinalizationProcessor
ExternalDataInstance
parsing that can be added to a newExternalInstanceParser
What has been done to verify that this works as intended?
New tests.
Why is this the best possible solution? Were any other approaches considered?
There's a lot of different ways we could go to get offline entities working. This is a first simple pass that focuses on getting the feature working and doesn't take into account additional goals like reducing the memory footprint of external secondary instances.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This only adds things so should be very low risk.