Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests based on findings from porting them to Web Forms #759

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Apr 16, 2024

Work in progress as we discover more of these

TODO:

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

@lognaturel lognaturel marked this pull request as draft April 16, 2024 17:19
@lognaturel lognaturel changed the title Use absolute references in body Standardize tests with unusual features Apr 16, 2024
input("value"),
input("label")),
input("/data/repeat/value"),
input("/data/repeat/label")),
input("filter"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one was missed (though another for the same name was caught below). I suspect there may be more. I'll try to catalogue them all so they can be updated together.

It's also unclear to me whether itemsets should be addressed the same way. E.g. should "../repeat" in the select1Dynamic call on the next line be /data/repeat? That might make sense here, but I'm less sure about extending that reasoning to relative itemset nodesets from within repeats.

These relative refs were likely introduced by analogy to itemset declarations
@lognaturel lognaturel changed the title Standardize tests with unusual features Improve tests based on findings from porting them to Web Forms May 23, 2024
lognaturel referenced this pull request in getodk/web-forms May 24, 2024
…output

Includes two alternates:

1. Adapt direct port to use proposed `Scenario` API
2. Fix apparent mistakes in test: it doesn’t exercise `jr:itext`, correctly close the itext id attribute

Adds proposed `labelRef` to form fixture DSL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants