Handle entities without IDs #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lognaturel
reviewed
May 25, 2024
lognaturel
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards getodk/collect#6109
What has been done to verify that this works as intended?
New tests.
Why is this the best possible solution? Were any other approaches considered?
The idea here is to still expose these entities, but make entity ID explicity null. Being more lenient here allows the UI (Collect) to make a decision about how it wants to deal with the problem. We could have altnernatively just hidden this happening, but that would restrict us from logging or even showing an error in the future.
The emerging philosophy here is that JavaRosa's
Entityis more of a representation of the XML node than of the conceptiual "entity" itself. The versioning logic disagress with this, but we'll be changing that soon most likely (with discussions ofrunIDetc).