Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Maven plugin for local publish #765

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Use Maven plugin for local publish #765

merged 2 commits into from
Jun 3, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented May 28, 2024

This replaces installLocal with publishToMavenLocal. This is a good baby step towards replacing Maven entirely with Gradle which will simplify development workflows.

We'll need to make a few updates on the Collect side after this, but that's fine to do after (and won't make sense to do before).

@seadowg seadowg marked this pull request as ready for review May 28, 2024 09:27
@seadowg seadowg requested review from lognaturel and removed request for lognaturel May 28, 2024 09:27
@seadowg seadowg marked this pull request as draft May 28, 2024 12:11
@seadowg seadowg marked this pull request as ready for review May 28, 2024 12:22
@seadowg seadowg requested a review from lognaturel May 28, 2024 12:23
Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was trying to verify this with Collect forgetting the comment that it's not supposed to work yet. I have confirmed that the expected artifacts are created.

@seadowg seadowg merged commit c546305 into getodk:master Jun 3, 2024
3 checks passed
@seadowg seadowg deleted the gradle branch June 3, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants