Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Maven compile scope dependencies in Gradle JAR #766

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 3, 2024

The build.gradle was declaring dependencies in an incompatible way to Maven. In Maven, the default scope (compile) includes the depdencies in the JAR. This is more analgous to Gradle's api than implementation (or compileOnly) which was being used and would mean that downstream dependencies would not recieve these. This creates problems for Collect which uses JavaRosa's included dependencies (like kxml for instance).

Down the line, we should move back to implementation, but I think that makes more sense once we've completely removed Maven.

@seadowg seadowg marked this pull request as ready for review June 3, 2024 12:43
@@ -48,13 +48,11 @@
<groupId>net.sf.kxml</groupId>
<artifactId>kxml2</artifactId>
<version>2.3.0</version>
<scope>compile</scope>
Copy link
Member Author

@seadowg seadowg Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably confusing things: compile is the default and doesn't need to be specified.

https://stackoverflow.com/questions/6646959/difference-between-maven-scope-compile-and-provided-for-jar-packaging

@lognaturel lognaturel merged commit f7bf5f2 into getodk:master Jun 3, 2024
3 checks passed
@seadowg seadowg deleted the fix-deps branch June 3, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants