Include Maven compile scope dependencies in Gradle JAR #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
commented
Jun 3, 2024
| @@ -48,13 +48,11 @@ | |||
| <groupId>net.sf.kxml</groupId> | |||
| <artifactId>kxml2</artifactId> | |||
| <version>2.3.0</version> | |||
| <scope>compile</scope> | |||
There was a problem hiding this comment.
This was probably confusing things: compile is the default and doesn't need to be specified.
lognaturel
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build.gradlewas declaring dependencies in an incompatible way to Maven. In Maven, the default scope (compile) includes the depdencies in the JAR. This is more analgous to Gradle'sapithanimplementation(orcompileOnly) which was being used and would mean that downstream dependencies would not recieve these. This creates problems for Collect which uses JavaRosa's included dependencies (likekxmlfor instance).Down the line, we should move back to
implementation, but I think that makes more sense once we've completely removed Maven.