Fix crash for non-String entity labels
#770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
changed the title
String entity labels
grzesiek2010
previously requested changes
Jun 13, 2024
|
|
||
| @Test | ||
| public void parseLabel_whenLabelIsAnInt_convertsToString() { | ||
| TreeElement labelElement = new TreeElement("label"); |
There was a problem hiding this comment.
I think we should have consts for values like this one label and maybe for some others too like id
lognaturel
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/collect#6167
What has been done to verify that this works as intended?
New tests!
Why is this the best possible solution? Were any other approaches considered?
Not a lot to discuss here. We now always convert to a string instead of casting, which should work for all the possible types.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The change is pretty specific, and will only affect entity forms.