Add way of providing external instances without an existing file #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
seadowg
commented
Jul 17, 2024
| @@ -44,7 +44,7 @@ static Map<String, String> parseAttributes(String name) { | |||
| Map<String, String> attributes = new HashMap<>(); | |||
| String[] words = name.split(" "); | |||
| for (String word : asList(words).subList(1, words.length)) { | |||
| String[] parts = word.split("(?<!\\))=(\"|')"); | |||
| String[] parts = word.split("(?<!\\))=(\"|')", 2); | |||
There was a problem hiding this comment.
I ran into this problem when working on a related tests in Collect. Basically select1Dynamic did not work with nodeset expressions like instance('things')/root/item[property='value'] because it would split on the second =.
There was a problem hiding this comment.
😮 That's a useful split signature I did not know about!
There was a problem hiding this comment.
Just discovered it myself!
lognaturel
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new interface
InstanceProviderwhich can be used to provide custom instance "parsing", but without needing an actual file to be referenced bysrc. This makes it a lot easier to write tests for custom parsing (we don't need to deal withReferenceManager) that don't actually care about the file insrc, and will allow us to also provide instances without an underlying file.What has been done to verify that this works as intended?
New tests.
Why is this the best possible solution? Were any other approaches considered?
We alternatively could have made
FileInstanceParserimplementations handle convertingsrcto an actual file path, but this would have meant changing that interface and also duplicating a bunch of code that's currently shared.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This just adds a new plugin interface, so there's not a lot of risk.