Close CSVParser properly and switch to record wise parsing to reduce memory use #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin! It seems like the CSV parsing code we had was using a different approach from the one we'd want for low memory (possibly to optimize for speed). It was clear from reading the docs that we were firstly not closing the resource properly, and secondly could be parsing files on a record-by-record basis.
I'd initially been looking to just write up an issue for this, but then realized the changes needed were very small.
I've created a
v4.4.xbranch for this to merge into as I'm thinking that we could do a hotfix release here and a corresponding one in Collect.