Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint/required validation UI #164

Merged
merged 42 commits into from
Aug 20, 2024
Merged

Constraint/required validation UI #164

merged 42 commits into from
Aug 20, 2024

Commits on Jul 30, 2024

  1. reset scroll in Demo app

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a3ab39d View commit details
    Browse the repository at this point in the history

  2. add new icons

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9467b61 View commit details
    Browse the repository at this point in the history

  3. Feature #130: Required and constraint validations

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4a92320 View commit details
    Browse the repository at this point in the history

  4. Styling changes

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    02c309b View commit details
    Browse the repository at this point in the history

  5. Refactor: use provide/inject for submitPressed. 

    * Instead of using CSS for sharing the state between components, I have used provide/inject method.
* Using input and blur events to determine when to show validation message
* Created a separate validation message component and consumed it in components for ControlNodes instead of having it in FormQuestion component
    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6c062f7 View commit details
    Browse the repository at this point in the history

  6. Moved Form level error message out of FormHeader

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2ce71eb View commit details
    Browse the repository at this point in the history

  7. use inset-inline-end instead of right for positioning error icon insi… 

    …de textbox
    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    29879d3 View commit details
    Browse the repository at this point in the history

  8. set width of form error message to 100% for smaller screens

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    811b6ce View commit details
    Browse the repository at this point in the history

  9. remove additional wrapper div that was added in .smaller-screen section

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3b5b6f7 View commit details
    Browse the repository at this point in the history

  10. change unit of scroll-margin-top from px to rem

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a2d4ec8 View commit details
    Browse the repository at this point in the history

  11. Scroll to first invalid question + focus it if it is a textbox

    @sadiqkhoja
    sadiqkhoja committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    62c7859 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. fix: submitPressed not provided error

    @sadiqkhoja
    sadiqkhoja committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c555db4 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. fix socio-economic-survey fixture 

    By removing required attribute from languageProficiency field with label only appearance
    @sadiqkhoja
    sadiqkhoja committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3cd4ae9 View commit details
    Browse the repository at this point in the history

  2. added component tests

    @sadiqkhoja
    sadiqkhoja committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0905461 View commit details
    Browse the repository at this point in the history

  3. Add todo tag for translations strings that are not in template

    @sadiqkhoja
    sadiqkhoja committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b27ad3c View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Remove fix-errors button 

    use popover instead of z-index
    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    3962122 View commit details
    Browse the repository at this point in the history

  2. fix: reduce heading size and weight

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    a74c439 View commit details
    Browse the repository at this point in the history

  3. fix: change background color of textboxes

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    65b5795 View commit details
    Browse the repository at this point in the history

  4. fix: make width of language change to max-content

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d33bc91 View commit details
    Browse the repository at this point in the history

  5. fix: reduce the spacing between questions in groups

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    91444be View commit details
    Browse the repository at this point in the history

  6. fix: remove shadow from the cards

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2268948 View commit details
    Browse the repository at this point in the history

  7. fix: add + icon for repeat add button. Also fix vertical spacing for … 

    …repeats
    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    808b248 View commit details
    Browse the repository at this point in the history

  8. fix: change the style of disabled textbox

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    a61fdc3 View commit details
    Browse the repository at this point in the history

  9. fix: flat the send button

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    73f4eb1 View commit details
    Browse the repository at this point in the history

  10. fix: increase the size of repeat number

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6be659c View commit details
    Browse the repository at this point in the history

  11. fix: size and style of repeat context menu

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0d8cf11 View commit details
    Browse the repository at this point in the history

  12. fix: align hamburger to the top + show options based on container size

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    019cdf6 View commit details
    Browse the repository at this point in the history

  13. fix: align chevron to the middle

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    41e038a View commit details
    Browse the repository at this point in the history

  14. fix: set background of the widget to white

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7cbf6f3 View commit details
    Browse the repository at this point in the history

  15. fix: align question container when it is inside groups

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    db1fce3 View commit details
    Browse the repository at this point in the history

  16. fix: gap between label and control

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    cf99dfd View commit details
    Browse the repository at this point in the history

  17. format all

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    1f24590 View commit details
    Browse the repository at this point in the history

  18. Increase max-width of language changer and min-width of container query

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8310581 View commit details
    Browse the repository at this point in the history

  19. set max-width of add repeat button to 260px

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    644de7c View commit details
    Browse the repository at this point in the history

  20. remove .chevron padding and make h2(flex) items align center

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ba86b4d View commit details
    Browse the repository at this point in the history

  21. use gap instead of margin between select options

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    1090b6b View commit details
    Browse the repository at this point in the history

  22. fix vertical alignment of validation message and no hover state for l… 

    …abel only checkboxes
    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    dfd58ea View commit details
    Browse the repository at this point in the history

  23. fix vertical alignment of icon and text in add button of repeats

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0eda90d View commit details
    Browse the repository at this point in the history

  24. added comment for negative left margin

    @sadiqkhoja
    sadiqkhoja committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2d6f7cb View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. use document scrolling instead of window

    @sadiqkhoja
    sadiqkhoja committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bb57e35 View commit details
    Browse the repository at this point in the history

  2. use vitest for mocking document properties and element methods 

    and split the OdkWebForm test into two
    @sadiqkhoja
    sadiqkhoja committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3e5c027 View commit details
    Browse the repository at this point in the history

  3. Create changeset

    @sadiqkhoja
    sadiqkhoja authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    82d35d0 View commit details
    Browse the repository at this point in the history