Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release lag #2725

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix release lag #2725

merged 1 commit into from
Apr 14, 2023

Conversation

carolynvs
Copy link
Member

What does this change

Use the latest magefiles package which has a fix for the lag time between when a release is created and when the assets are uploaded. The release should stay in draft mode now until the release is successful.

What issue does it fix

Closes #2723

Notes for the reviewer

We can test this out by running /azp run test-porter-release, which creates the release on my fork

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Use the latest magefiles package which has a fix for the lag time between when a release is created and when the assets are uploaded. The release should stay in draft mode now until the release is successful.

Fixes getporter#2723

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review April 14, 2023 13:53
@carolynvs carolynvs merged commit 9a61baf into getporter:main Apr 14, 2023
@carolynvs carolynvs deleted the fix-release-lag branch April 14, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-linux.sh 'latest' is producing a 404 error
1 participant