Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce emeritus maintainers #2728

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Introduce emeritus maintainers #2728

merged 2 commits into from
Apr 24, 2023

Conversation

carolynvs
Copy link
Member

What does this change

I have taken the template text from the CNCF project template for the contributor ladder at https://raw.githubusercontent.com/cncf/project-template/30f45e1b5be5fd586ba17e83b6501d1721a7970a/CONTRIBUTOR_LADDER.md and used it to define Emeritus Maintainers.

This pretty much follows what was originally proposed in #2546, and includes paths for involuntary removal, and resuming maintainership status.

What issue does it fix

Closes #2546

Notes for the reviewer

Since this is changing our governance, this should be approved by a majority of active maintainers who have contributed in the past 6 months: @carolynvs, @VinozzZ, @sgettys, @bdegeeter. Non-active maintainers are welcome to vote too or ask to move to Emeritus status.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

I have taken the template text from the CNCF project template for the contributor ladder at https://raw.githubusercontent.com/cncf/project-template/30f45e1b5be5fd586ba17e83b6501d1721a7970a/CONTRIBUTOR_LADDER.md and used it to define Emeritus Maintainers.

This pretty much follows what was originally proposed in getporter#2546, and includes paths for involuntary removal, and resuming maintainership status.

Closes getporter#2546

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review April 14, 2023 16:41
@carolynvs
Copy link
Member Author

I'll keep this open until Friday so that everyone has time to comment and then I'll merge since we have a majority vote.

@carolynvs carolynvs merged commit 6a4f1bb into getporter:main Apr 24, 2023
@carolynvs carolynvs deleted the emeritus branch April 24, 2023 13:43
bdegeeter pushed a commit to bdegeeter/porter that referenced this pull request May 11, 2023
* Introduce emeritus maintainers

I have taken the template text from the CNCF project template for the contributor ladder at https://raw.githubusercontent.com/cncf/project-template/30f45e1b5be5fd586ba17e83b6501d1721a7970a/CONTRIBUTOR_LADDER.md and used it to define Emeritus Maintainers.

This pretty much follows what was originally proposed in getporter#2546, and includes paths for involuntary removal, and resuming maintainership status.

Closes getporter#2546

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>

* Remove unused heading

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>

---------

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define emeritus maintainer status
5 participants