Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Artifactory as a supported registry #2747

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Apr 24, 2023

What does this change

We have validated that Artifactory works with Porter and I have updated our compatible registry page to reflect that.

#2324 (comment)

Thanks to @alekseybb197 for the validation! 🎉

What issue does it fix

Closes #2324

Notes for the reviewer

Preview at https://deploy-preview-2747--porter.netlify.app/compatible-registries/

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

We have validated that Artifactory works with Porter and I have updated our compatible registry page to reflect that.

getporter#2324 (comment)

Thanks to @alekseybb197 for the validation! 🎉

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
* Do not use bold to indicate compatible registries
* Sort in alphabetical order
* Use red/green emoji to make for easier scanning

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review April 24, 2023 16:01
@carolynvs carolynvs merged commit 4c10d98 into getporter:main Apr 25, 2023
@carolynvs carolynvs deleted the artifactory-supported branch April 25, 2023 15:10
bdegeeter pushed a commit to bdegeeter/porter that referenced this pull request May 11, 2023
* Mark Artifactory as a supported registry

We have validated that Artifactory works with Porter and I have updated our compatible registry page to reflect that.

getporter#2324 (comment)

Thanks to @alekseybb197 for the validation! 🎉

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>

* Improve compatible registry formatting

* Do not use bold to indicate compatible registries
* Sort in alphabetical order
* Use red/green emoji to make for easier scanning

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>

---------

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate Porter with Artifactory
2 participants