Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generating changelog.md using github actions! #2837

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

itsaviral2609
Copy link
Contributor

This PR will close down the issue #2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!

Tested this on my feature branch with my local forked repo and my branch and made changes suggested by @schristoff and @troy0820 for master branch case!

 + git push origin main
 - git push origin master
 jobs:
  changelog:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v3.3.0
        with:
          ref: main
          fetch-depth: 0
          token: ${{ secrets.GH_PAT }}

Replaced master by main as discussed

What issue does it fix

Closes #2797

If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.

Notes for the reviewer

Please review my PR and suggest any changes if any 😄
And apology to @schristoff for making it difficult to review earlier
Thanks for being patient and kind :)

Checklist

  • Did you write tests?
  • Wrote workflow
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!

fixes: getporter#2797
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
with:
ref: main
fetch-depth: 0
token: ${{ secrets.GH_PAT }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using this instead - otherwise looks great!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schristoff cool! gonna use this then.

token: ${{ secrets.GITHUB_TOKEN  }}

Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
 into itsaviral-changelog

Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
@itsaviral2609
Copy link
Contributor Author

@schristoff Made the requested changes :)

Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@schristoff schristoff merged commit 21319b1 into getporter:main Aug 1, 2023
7 checks passed
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* feat: Generating changelog.md using github actions!

This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!

fixes: getporter#2797
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* feat: Generating changelog.md using github actions!

This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!

fixes: getporter#2797
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* feat: Generating changelog.md using github actions!

This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!

fixes: getporter#2797
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* feat: Generating changelog.md using github actions!

This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!

fixes: getporter#2797
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Automate changelog.md
2 participants