Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clarification for STATE and STATUS #2843

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Jul 28, 2023

What does this change

Clarifies what STATE and STATUS fields are in porter list.

What issue does it fix

Closes #2357

Notes for the reviewer

Feedback appreciated

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@ludfjig ludfjig marked this pull request as ready for review July 28, 2023 20:14
@ludfjig ludfjig changed the title added draft clarification for STATE and STATUS added clarification for STATE and STATUS Jul 28, 2023
@schristoff
Copy link
Member

schristoff commented Jul 31, 2023

This is amazing! Thank you so much for this contribution. A small ask, I was hoping to have a matrix showing the different states and statuses we could have. For example:

State          Status             Meaning
________|___________|______________|
defined      failed.            blah

please pretend that it is lined up it looks nicer before it tries to format it

@ludfjig
Copy link
Contributor Author

ludfjig commented Jul 31, 2023

image
Feedback appreciated :), table looks a little bit funky

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution to our documentation!

@schristoff schristoff merged commit aa124eb into getporter:main Aug 1, 2023
5 checks passed
@ludfjig ludfjig deleted the docs-installation branch August 1, 2023 20:11
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* added draft clarification for STATE and STATUS

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* added draft clarification for STATE and STATUS

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* added draft clarification for STATE and STATUS

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
* added draft clarification for STATE and STATUS

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation showing up as defined after a run has failed
2 participants