Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update all the things #2851

Merged
merged 6 commits into from
Aug 3, 2023
Merged

chore: update all the things #2851

merged 6 commits into from
Aug 3, 2023

Conversation

schristoff
Copy link
Member

Resolves a bunch of open dependabot issues

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@schristoff
update all the things
c12daef 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@schristoff
Merge branch 'main' into schristoff_gomodtidy
a2d2868 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
troy0820
troy0820 requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with all the updates, just a couple of changes that help with errors and deletes an interface we don't need.

pkg/build/buildkit/buildx.go Outdated Show resolved Hide resolved
pkg/build/buildkit/buildx.go Outdated Show resolved Hide resolved
pkg/build/build.go Outdated Show resolved Hide resolved
schristoff and others added 3 commits August 1, 2023 11:56
@schristoff @troy0820
Update pkg/build/buildkit/buildx.go
b42709f 
Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff @troy0820
Update pkg/build/buildkit/buildx.go
143d262 
Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff @troy0820
Update pkg/build/build.go
a9a90e1 
Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
troy0820
troy0820 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schristoff schristoff merged commit 6b38bd4 into getporter:main Aug 3, 2023
16 checks passed
@schristoff schristoff deleted the schristoff_gomodtidy branch August 3, 2023 02:59
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@schristoff @troy0820
chore: update all the things (getporter#2851)
97aa4a7 
* update all the things

Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@schristoff @troy0820
chore: update all the things (getporter#2851)
9cc092f 
* update all the things

Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@schristoff @troy0820
chore: update all the things (getporter#2851)
64fb073 
* update all the things

Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@schristoff @troy0820
chore: update all the things (getporter#2851)
be7ab54 
* update all the things

Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troy0820 troy0820 troy0820 approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schristoff @troy0820