Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where unwanted v is prepended to tag name #2915

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Sep 19, 2023

What does this change

Fixes bug

What issue does it fix

Closes #2914

If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig changed the title Fix bug when v is appended to tag Fix bug when unwanted v is appended to tag name Sep 19, 2023
@ludfjig ludfjig changed the title Fix bug when unwanted v is appended to tag name Fix bug where unwanted v is appended to tag name Sep 19, 2023
@ludfjig ludfjig changed the title Fix bug where unwanted v is appended to tag name Fix bug where unwanted v is prepended to tag name Sep 19, 2023
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj adding test

@schristoff
Copy link
Member

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@schristoff
Copy link
Member

if it is telemetry test just merge anyways

@ludfjig ludfjig enabled auto-merge (squash) September 19, 2023 20:59
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are facing test failures, outside of this changeset. These are non-blocking but it would be nice if you could get them in.

pkg/porter/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/porter/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/porter/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/porter/lifecycle_test.go Show resolved Hide resolved
ludfjig and others added 2 commits September 20, 2023 15:34
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig merged commit 23ab83a into getporter:main Sep 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"v" prefix is prepended to tag when it shouldn't be
3 participants