-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where unwanted v is prepended to tag name #2915
Conversation
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gj adding test
/azp run porter-integration |
Azure Pipelines successfully started running 1 pipeline(s). |
if it is telemetry test just merge anyways |
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are facing test failures, outside of this changeset. These are non-blocking but it would be nice if you could get them in.
What does this change
Fixes bug
What issue does it fix
Closes #2914
If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
Reviewer Checklist