chore: Swap out integration test in release pipeline #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
schristoff
requested review from
sgettys,
bdegeeter and
troy0820
as code owners
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
troy0820
approved these changes
Feb 5, 2024
| registry: | ||
| type: string | ||
| required: false | ||
| default: ghcr.io |
There was a problem hiding this comment.
Does this need to be scoped to ghcr.io/getporter/porter ?
| @@ -110,7 +137,7 @@ jobs: | |||
| - name: Docker Login | |||
| uses: docker/login-action@v3.0.0 | |||
| with: | |||
| registry: ghcr.io | |||
| registry: ${{inputs.registry}} | |||
There was a problem hiding this comment.
Do we need to build the docker images in the integration tests? Should this be another workflow after we see that the tests are passing?
| copy_integration_test: | ||
| uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main | ||
| with: | ||
| test_name: copy_test | ||
| test_name: copy_tests | ||
| registry: ${{inputs.registry}} |
There was a problem hiding this comment.
Is this necessary for each stage of the pipeline if it is not using it?
| @@ -30,7 +33,7 @@ jobs: | |||
| - name: Docker Login | |||
| uses: docker/login-action@v3.0.0 | |||
| with: | |||
| registry: ghcr.io | |||
| registry: ${{inputs.registry}} | |||
There was a problem hiding this comment.
Same thing here, do we need to log in to the registry to build the images?
| @@ -6,6 +6,9 @@ on: | |||
| test_name: | |||
| type: string | |||
| required: false | |||
| registry: | |||
| type: string | |||
| required: false | |||
There was a problem hiding this comment.
If this is not required, should we set a default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.